[Webkit-unassigned] [Bug 26126] Refactor methods of WorkerMessagingProxy used to talk to main-thread loader into new interface.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26126





------- Comment #3 from dimich at chromium.org  2009-06-08 18:37 PDT -------
(In reply to comment #2)
> (From update of attachment 30850 [review])
> > +		18F831B80FD48C7800D8C56B /* WorkerLoaderProxy.h in Headers */ = {isa = PBXBuildFile; fileRef = 18F831B70FD48C7800D8C56B /* WorkerLoaderProxy.h */; };
> 
> Is this out of order?

Seems ok in the xcode itself (the file is in right alphabetical order in the
Sources). 

> > diff --git a/WebCore/loader/WorkerThreadableLoader.cpp b/WebCore/loader/WorkerThreadableLoader.cpp
> Is it possible to remove the #include "WorkerMessagingProxy.h"?

Yes, removed. Instead, included WorkerLoaderProxy.h

> > +WorkerThreadableLoader::MainThreadBridge::MainThreadBridge(PassRefPtr<ThreadableLoaderClientWrapper> workerClientWrapper, WorkerLoaderProxy* loaderProxy, const String& taskMode,
> 
> Ideally loaderProxy would be a & since it can never be 0.

Done, also changed WorkerThread::workerLoaderProxy and
WorkerThread::workerObjectProxy to return &, accordingly.

> > diff --git a/WebCore/workers/WorkerLoaderProxy.h b/WebCore/workers/WorkerLoaderProxy.h
> > +
> > +        virtual ~WorkerLoaderProxy() {}
> Nice to have a space in { }.

Done.

> > +        // Postst callbacks from loading code to the WorkerContext. The 'mode' is used to differentiate
> 
> Postst spelling.

Fixed.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.