[Webkit-unassigned] [Bug 26242] [GTK] The way we handle optional features is not quite right

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26242





------- Comment #1 from christian at twotoasts.de  2009-06-07 11:59 PDT -------
The funny thing is, when I look at bug 25263, I remember a discussion in IRC
about compile time GNOME features, ending with a conclusion that it's the wrong
approach. But I missed that bug report completely.

I completely agree that the current situation is completely silly from a
packaging point of view. Currently Midori does in fact never make use of
libsoup-gnome because it would have to be compiled with it, which means more
than one unwanted dependency for a lot of users. And other users want it
because they do have the packages anyway.

I find the suggestion of separate modules very good, with a) a function that
tells me if the feature is installed b) a function to enable the feature
regardless of whether it is available.

Maybe something like webkit_has_feature ("keyring") and webkit_set_feature
("keyring", TRUE), or alternatively webkit_web_settings_has_feature
/_set_feature. Particularly using strings instead of defines would completely
avoid the compile time dependency problem.

Spell check would probably also be a module.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.