[Webkit-unassigned] [Bug 25376] Refactor localStorage code for use in multi-process browsers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 5 15:37:55 PDT 2009


------- Comment #6 from jorlow at chromium.org  2009-06-05 15:37 PDT -------
Created an attachment (id=31014)
 --> (https://bugs.webkit.org/attachment.cgi?id=31014&action=view)
Patch 2 in this set

I'm trying to make these patches as small and self contained as possible.  I'll
continue rolling them out while I wait on reviews for earlier ones.  I'm now
using git with a branch for each one, so I should be able to keep all the
layers straight.....but prompt reviews are obviously going to make this easier
on everyone.

This is the second patch in the set.  It takes another step towards abstracting
out the sync process.  In this case, it's getting rid of all the
'internalGetItem' (and associated calls) and instead replaces them with one
virtual function call that'll block until the import is complete.

I'm pretty sure that the behavior for setItem, removeItem, and clear are NOT
safe.  getItem and contains do have a small optimization that is legit, but I'm
don't think it helps a whole lot in practice since, if it's not present right
away, it'll block until the import is complete.

I've made a FIXME comment about possible optimizations.  I'd like to implement
this after a couple more rounds of refactoring.

Unlike most svn patches, this needs to be applied with 'patch -p1' instead of
'patch -p0'.  I'll create a ChangeLog and finalize this patch once the first
one is reviewed.  I'm putting this (and probably more soon) up mostly as a FYI.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list