[Webkit-unassigned] [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc}

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 4 20:50:57 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26148


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30983|review?                     |review-
               Flag|                            |




------- Comment #14 from eric at webkit.org  2009-06-04 20:50 PDT -------
(From update of attachment 30983)
Looks great!

In response to your IRC question, yes WebKit avoids non pod globals because
they slow down library load/startup time.  So you're right that you'll need to
fix defaultGUIFont to use a function or some other solution.

Typo:
+           1) Createion of a caretBlinkIntervalInternal.

Looks great otherwise.

r- because I'm worried the global constructor could cause build bots to break.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list