[Webkit-unassigned] [Bug 26202] New: add macros for primitive values to simplify CSSStyleSelector::applyProperty
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 4 20:00:15 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=26202
Summary: add macros for primitive values to simplify
CSSStyleSelector::applyProperty
Product: WebKit
Version: 528+ (Nightly build)
Platform: PC
OS/Version: All
Status: UNCONFIRMED
Severity: Enhancement
Priority: P5
Component: WebCore Misc.
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: rolandsteiner at google.com
[separated out from bug #26198]
Like the other HANDLE_... macros used I added 2 more that also include the
handling of primitive values. Using that allows to reduce the line count quite
a bit.
NOTE: There are some CSS properties that do not query whether a value is
actually a primitive value, but do an assignment unconditionally. AFAICT, this
would result in the asignment of a default value if the passed-in value is not,
in fact, primitive.
As these cases should only occur with malformed input anyway, and as the UA is
supposed to ignore erroneous values, I believe my changes are correct in these
cases.
There was no change in layout test results.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list