[Webkit-unassigned] [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc}

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26148


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30974|review?                     |review-
               Flag|                            |




------- Comment #12 from eric at webkit.org  2009-06-04 19:27 PDT -------
(From update of attachment 30974)
Why re-order paintMediaButtonInternal ?  Leaving it where it was makes the
patch easier to read.

Why re-order menuListInternalPadding?  Same as above...

Why wouldn't this just be a String or an AtomicString?
static const char* defaultGUIFont;
That would save conversions on every use.

Yeah, I think a little shuffling and splitting could make this diff much
smaller.  Hard to review at this size. :(


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.