[Webkit-unassigned] [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc}

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 4 17:16:33 PDT 2009


ajwong at chromium.org changed:

           What    |Removed                     |Added
  Attachment #30974|                            |review?
               Flag|                            |

------- Comment #10 from ajwong at chromium.org  2009-06-04 17:16 PDT -------
Created an attachment (id=30974)
 --> (https://bugs.webkit.org/attachment.cgi?id=30974&action=view)
Factors out a common RenderThemeChromiumSkia class and makes
RenderThemeChromiumLinux and RenderThemeChromiumWin depend on it.

The only bits left in RenderThemeChromiumLinux are the methods taht the windows
version does not override itself.

Here are the changes that were not just pure code shuffling:
  1) defaultFontSize was combined, and turned into a protected class member
  2) defaultGUIFont was combined, and turned into a protected class member. 
The windows code needed some extra type conversion code added to make this
  3) caretBlinkInterval was split into caretBlinkInterval and
caretBlinkIntervalInternal to centralize the layout test special code path.

The rest should be just shuffling of code around.

Note that there is a bit of a wart in that some resources referred to by
RenderThemeChromiumSkia have names like themeWinUserAgentStyleSheet, or
linuxCheckboxOn.  I dont' think the naming is hurtful enough to bother cleaning
up at this point.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list