[Webkit-unassigned] [Bug 26198] Misc. code cleanup and simplification

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 4 16:02:37 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26198





------- Comment #2 from rolandsteiner at google.com  2009-06-04 16:02 PDT -------
Created an attachment (id=30964)
 --> (https://bugs.webkit.org/attachment.cgi?id=30964&action=view)
add macro for primitive values

Like the other HANDLE_... macros used I added 2 more that also include the
handling of primitive values. Using that allows to reduce the line count quite
a bit.

NOTE: There are some CSS properties that do not query whether a value is
actually a primitive value, but do an assignment unconditionally. AFAICT, this
would result in the asignment of a default value if the passed-in value is not,
in fact, primitive. 
As these cases should only occur with malformed input anyway, and as the UA is
supposed to ignore erroneous values, I believe my changes are correct in these
cases. 

There was no change in layout test results.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list