[Webkit-unassigned] [Bug 26187] Canvas initial lineWidth not in sync with graphics backends.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 4 12:42:01 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26187


oliver at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30947|review?                     |review-
               Flag|                            |




------- Comment #2 from oliver at apple.com  2009-06-04 12:42 PDT -------
(From update of attachment 30947)
The fix itself looks good but i don't like the layout test.  You should look at
the design of the more modern canvas tests -- they're basically the same
structure as JS ones so find a test which has the following

fast/canvas/test-name.html // html document will just have some boiler plate
that includes a couple of js files, resoureces/test-name.js and then another js
file
fast/canvas/resources/test-name.js // The actual test itself

I *think* the isPointInPath tests cases will be of this newer style.   The
newer style is vastly more useful as we use getImagedata to anaylse the result
of drawing rather than relying on pixel comparisons.  This is especially
benefical given people typically do no run pixel tests, but also because it's
much easier to see what is being tested.

--Oliver


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list