[Webkit-unassigned] [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc}

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 4 12:14:01 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26148


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30884|review?                     |review-
               Flag|                            |




------- Comment #3 from eric at webkit.org  2009-06-04 12:14 PDT -------
(From update of attachment 30884)
I think this would be less error-prone if you renamed the class inside
RenderThemeChromiumLinux.* first.  Then you could make Windows depend on it. 
And then you could finally move the file instead of copying it, as the last
step.  If you feel strongly this order is better, that's OK with me, but you'll
just have to be sure to check extra careful at the end to make sure no other
modifications to the file slipped in during your move...


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list