[Webkit-unassigned] [Bug 13128] Safari not obeying cache header
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 4 10:41:24 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=13128
------- Comment #20 from koivisto at iki.fi 2009-06-04 10:41 PDT -------
(In reply to comment #19)
> Any particular reason the constructors were moved from the header into the
> source file? They won't be inlined any longer if they're defined here.
To avoid gratuitous inilining. :)
Mostly to avoid triggering large recompiles on modifications. I don't think
responses are constructed in sufficient numbers for inlining to be important.
> Any 64-bit class size considerations here? I think Simon was moving doubles
> above bool bitfields in other classes. Maybe it would be a good idea to group
> the bool bitfields together even if you have to switch between private and
> protected.
I don't see how reordering would help here. MIcro optimizing here is not
massively important in any case.
> The only thing that I want to do is to compare the RFC language to the
> implementation. (Thanks for adding appropriate comments to the source!)
> Otherwise, this patch looks great!
Thanks!
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list