[Webkit-unassigned] [Bug 26061] [SKIA] Crash when filling an empty pattern

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 4 09:05:17 PDT 2009


eric at webkit.org changed:

           What    |Removed                     |Added
  Attachment #30735|review?                     |review+
               Flag|                            |

------- Comment #2 from eric at webkit.org  2009-06-04 09:05 PDT -------
(From update of attachment 30735)
The patch looks fine.

I would have used a named constant for the color.  I'm surprised that skia
doesn't have a "transparent" constant that you can return instead of having to
manually construct a color.

Color::transparent is identical, and is guaranteed to be the right format due
to COMPILE_ASSERT checks in ColorSkia.cpp.

Tab indent should be 4 spaces, not 2.

Those are both nits someone could fix when landing.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list