[Webkit-unassigned] [Bug 26180] If "otherOrigin == this" in SecurityOrigin::equal, it's obviously equal.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26180





------- Comment #3 from jorlow at chromium.org  2009-06-03 20:23 PDT -------
I don't think so.  I only see isSameSchemeHostPort used a couple places, but
they don't seem like they'd benefit from such an optimization [1].  ::equal, on
the other hand, is called pretty often (it's used a lot in hash tables).  It
seems a bit painful to require another function call plus a branch or two for a
function that's not called very often.

We could put the == check in both places.  Doing one additional branch isn't
going to hurt the slow path.  It doesn't seem necessary though.

[1]
http://www.google.com/codesearch?hl=en&q=isSameSchemeHostPort+package%3A%22git%3A%2F%2Fandroid.git.kernel.org%2Fplatform%2Fexternal%2Fwebkit.git%22


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.