[Webkit-unassigned] [Bug 26180] New: If "otherOrigin == this" in SecurityOrigin::equal, it's obviously equal.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26180

           Summary: If "otherOrigin == this" in SecurityOrigin::equal, it's
                    obviously equal.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P3
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jorlow at chromium.org


If "otherOrigin == this" in SecurityOrigin::equal, it's obviously equal.

>From http://lists.macosforge.org/pipermail/webkit-dev/2009-June/008038.html

> SecurityOrigin was created to cleanup the way we do same-origin checks in
> the JavaScript bindings, and as such, carry some of that baggage (eg. domain
> relaxing).  The main design constraint then was that it was a cheap compare
> for two origins representing the same document (pointer compare) as that is
> common case.  The code evolved from there.

Makes sense.  Note that SecurityOrigin::equal does not currently do a fast
path check of "this == other" (to just do a pointer compare as you
mentioned) so this is probably low hanging fruit to make things a bit
faster.  (Though, as you said, it's not showing up on current profiles...so
it's probably not a huge deal.)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.