[Webkit-unassigned] [Bug 26030] [Chromium] Chromium Linux ignores background color on <select>.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 3 17:16:10 PDT 2009


eric at webkit.org changed:

           What    |Removed                     |Added
  Attachment #30920|review?(eric at webkit.org)    |review-
               Flag|                            |

------- Comment #7 from eric at webkit.org  2009-06-03 17:16 PDT -------
(From update of attachment 30920)
I would have given this color a name:
 129         return 0xffdddddd;

static Color someNiceNameForTheColor(0xffdddddd);
return someNiceNameForTheColor;

Braces get their own line:
 264 static float brightenColorCap(float in) {

Single line ifs don't get braces:
292     if (max == min) {
 293         hue = 0.f;
 294     } else if (max == r) {

Color functions belong on Color.h or somewhere in Skia...
 282 static SkColor brightenColor(SkColor base, float brightenAmount)

256341 static void paintButtonLike(RenderTheme* theme, RenderObject* o, const
RenderObject::PaintInfo& i, const IntRect& rect) {
 need { on its own line too.

WK of course uses CamelCase:
 334     int final_r = 255.f * brightenColorDecode(p, q, tr);

Looks nice though! :)

r- for color stuff needing to move somewhere else.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list