[Webkit-unassigned] [Bug 26174] [Chromium] Change scrollbar theme code to use different classes on Windows and Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26174


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30926|review?(eric at webkit.org)    |review+
               Flag|                            |




------- Comment #2 from eric at webkit.org  2009-06-03 15:32 PDT -------
(From update of attachment 30926)
spelling:
 6         Windows and Linux rather than suppling symbols. The ScrollbarTheme
I think you meant supplying.

I know you're just moving, but we don't name arguments when the names don't add
anything:
42         virtual void paintTrackPiece(GraphicsContext* gc, Scrollbar*
scrollbar, const IntRect& rect, ScrollbarPart partType);
 43         virtual void paintButton(GraphicsContext* gc, Scrollbar* scrollbar,
const IntRect& rect, ScrollbarPart partType);
 44         virtual void paintThumb(GraphicsContext* gc, Scrollbar* scrollbar,
const IntRect& rect);

Looks sane to me.  r+ you can fix the above nits when landing.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.