[Webkit-unassigned] [Bug 26164] webkit/jit stack mis-aligned for double on MIPS platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26164


barraclough at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WORKSFORME




------- Comment #1 from barraclough at apple.com  2009-06-03 15:21 PDT -------
Cannot reproduce a problem on ToT.

On OS X x86, the stack should always be 16-byte aligned prior to making a call,
the call pushes the return address decrementing %esp by 4, and as such on
function entry the %esp value should always containing a value ending in 0xC. 
Adding a breakpoint to JSC::Lexer::lex & testing this, I observe correct
behavior.  From visual code inspection of the machine trampolines, they are
currently correctly implemented, and are not misaligning the stack.  When,
during implementation, there have been alignment issues in the JIT these have
causes crashes (memcpy can use aligned SSE accesses), as such we would expect
to know.

Can you provide steps to reproduce a problem here?  Otherwise, marking this
'works for me'.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.