[Webkit-unassigned] [Bug 26154] SecurityOrigin::createFromDatabaseIdentifier should handle _'s in the hostname

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 3 13:00:13 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26154


jorlow at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30891|0                           |1
        is obsolete|                            |




------- Comment #5 from jorlow at chromium.org  2009-06-03 13:00 PDT -------
Created an attachment (id=30921)
 --> (https://bugs.webkit.org/attachment.cgi?id=30921&action=view)
Fixed spacing in comment + ChangeLog issues

(In reply to comment #4)
> (In reply to comment #3)
> > It's really too bad there's no way to write unittests in WebKit
> > since this is basically a perfect example of what they're really useful for.  
> 
> There's no reason for you to settle for the status quo. Everything about our
> testing infrastructure was created by someone at one point to solve a problem
> like the one you just mentioned. You could be the person who made this
> possible. Exposing some particular function to JavaScript is all it takes to
> make a particular unit test in our existing framework; that has been done many
> times. There's an experimental feature in the Mac DumpRenderTree that lets
> JavaScript call any Objective-C method, too. You could invent a new approach.
> Maybe you could bring unit tests as you know them from other projects to this
> project.
> 
> Please don't assume that someone else is going to fix this!

Created https://bugs.webkit.org/show_bug.cgi?id=26171

> > Anyway, would you like me to fix the ChangeLog + 2 spaces issue and send
> > another patch, or did you + it since a committer can easily do that?
> 
> It'd be kind for you to do that. Really depends on the committer how they feel
> about doing such minor chores.

Done.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list