[Webkit-unassigned] [Bug 25475] Show the filename and first line for "(program)" in the Profiler/Debugger

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25475





------- Comment #8 from timothy at hatcher.name  2009-06-03 07:00 PDT -------
(In reply to comment #7)
> I poked around a bit yesterday, looking for an appropriate place and method to
> do testing for this functionality.  Looking at the profiler tests, I realized
> that sourceURLs show up in the output for profile output, so that seemed like a
> possibility.  However, as I tried this out, it turns out that profiling does
> NOT pick up the overridden sourceURL specified using the //@sourceURL=
> technique.  I suspect the JS VM is actually providing this information directly
> to the profile code, as opposed to going through Script.js.
> 
> This in itself may be a problem - SHOULD the overridden sourceURL show up in
> profiles?  I did a little profiling work, and found that while it would be
> nice, it's not clear to me that this is a stopper sort of issue.  Something to
> look into later perhaps.  
> 
> I also realized that console.trace() can show sourceURLs, but it also did not
> not show the overridden version.  Again, doesn't seem to me to be a stopper
> issue.

Making these work will be tricky and require the change to be in JavaScriptCore
directly. It can wait, but a bug should be filed about them.

> At this point, I don't think there is any way to add verifiable tests, but we
> should add some manual tests.  There are some files in
> LayoutTests/fast/inspector which appear to be manual tests, or could be; ie,
> there are .html files with no corresponding -expected.txt files with them. 
> Would it be appropriate to add manual tests by adding an additional .html file
> with no -expected.txt file, in that directory?

Nothing in LayoutTests is manual, they all run with the run-webkit-tests
script. Th expected results are in the LayoutTests/platform dir.

Manual tests for the Inspector can be found in WebCore/manual-tests/inspector.

I will reply later about your other comments, to busy this week and next with
WWDC. Just didn't want you to think I was ignoring you here.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.