[Webkit-unassigned] [Bug 26154] New: SecurityOrigin::createFromDatabaseIdentifier should handle _'s in the hostname

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26154

           Summary: SecurityOrigin::createFromDatabaseIdentifier should
                    handle _'s in the hostname
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P3
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jorlow at chromium.org


As Adam Barth mentioned:
> There are a bunch of problems with
> SecurityOrigin::databaseIdentifier(), not the least of which is that
> "_" can't really be used as a delimiter because some intranet host
> names contain the character in their names.  I'd rather we didn't used
> databaseIdentifier() and had a single string representation we used
> everywhere.

It seems like a good first step towards a fix is to search for only the first
and the last _ and assume everything in between is the host name.  This would
choke on any protocols/schemes with an underscore in it, but the old code would
have as well, and it's not clear to me how to handle this gracefully.

The original thread:
http://lists.macosforge.org/pipermail/webkit-dev/2009-June/008038.html
http://lists.macosforge.org/pipermail/webkit-dev/2009-June/008043.html


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.