[Webkit-unassigned] [Bug 26114] CString undeclared in PlatformString.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26114





------- Comment #3 from coolwanglu at gmail.com  2009-06-02 22:05 PDT -------
(In reply to comment #2)
> Yes, this is by design. Not including unnecessary headers makes compilation
> faster (e.g. if CString.h changes, the build system won't need to recompile all
> files that include PlatformString.h).

This is true, but it might confuse programmers, at least some comment might be
helpful. It took me really some time to figure this out.

Besides, is this the only case? and why optimize for CString.h? Is it
'mutable'?

> 
> > I checked several source files in WebCore, CString.h is always included before
> > PlatformString.h.
> 
> In a vast majority of cases, CString.h in not included before PlatformString.h.
> Actually, there are only two rarely used methods in PlatformString,h that need
> CString.h.
> 
Maybe I was wrong, I'll check again.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.