[Webkit-unassigned] [Bug 26030] [Chromium] Chromium Linux ignores background color on <select>.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26030


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30881|review?(eric at webkit.org)    |review-
               Flag|                            |




------- Comment #5 from eric at webkit.org  2009-06-02 15:13 PDT -------
(From update of attachment 30881)
Still has the { } style issues.

The .css file should be a real .css file on disk and go through the normal
processing scripts, no?


I think I would have written this:
+        if (!o->style()->hasBackground()) {
+            paint.setARGB(0xff, 0xe9, 0xe9, 0xe9);
+        } else {
+            paint.setColor(o->style()->backgroundColor().rgb());
+        }

As something like:

static Color defaultButtonGrey(0xff, 0xe9, 0xe9, 0xe9);
Color buttonBackground = !o->style()->hasBackground() ?
o->style()->backgroundColor() : defaultButtonGrey;
paint.setColor(buttonBackground.rgb());

But this makes me wonder if CSS buttons (which do not go through the button
theme calls) will look correct w/o a background?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.