[Webkit-unassigned] [Bug 26148] New: Unfork RenderThemeChromium{Win, Linux}.{h, cc}

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 2 15:09:17 PDT 2009


           Summary: Unfork RenderThemeChromium{Win,Linux}.{h,cc}
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ajwong at chromium.org

There is a lot of duplicated code between RenderThemeChromiumWin and Linux. 
Currently the Linux branch is completely generic Skia code. Thus, rename
RenderThemeChromiumLinux -> RenderThemeChromiumSkia. Then have
RenderThemeChromiumWin inherit off of RenderThemeChromiumSkia.

Since this code's dependencies straddle the chromium and webkit trees, the
refactor will require multiple commits as to keep both trees green.

Expected Steps:
  1) _copy_ RenderThemeChromiumLinux to RenderThemeChromiumSkia with
appropriate renamings internally.
  2) Update chromium code to break dependency on RenderThemeChromiumLinux (send
announcement to chromium-dev), and to build RenderThemeChromiumSkia files.
  3) Make RenderThemeChromiumWin inherit off of RenderThemeChromiumSkia. Delete
RenderThemeChromiumLinux files.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list