[Webkit-unassigned] [Bug 26030] [Chromium] Chromium Linux ignores background color on <select>.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 2 15:06:07 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26030


agl at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30682|0                           |1
        is obsolete|                            |
  Attachment #30881|                            |review?(eric at webkit.org)
               Flag|                            |




------- Comment #3 from agl at chromium.org  2009-06-02 15:06 PDT -------
Created an attachment (id=30881)
 --> (https://bugs.webkit.org/attachment.cgi?id=30881&action=view)
patch

Changes:

1) Color::rgb does indeed return a value which is
   compatible. However, it seems be a bit of a leap that the
   internal format of both Color and SkColor is register
   ARGB. Other platforms define specific constructors in
   Color. However, both RGBA32 and SkColor unwrap to an
   unsigned int, so we can't do that here.

   I've used .rgb() because it works and it's cleaner. I
   guess layout tests will catch if either side ever
   changes.

2) html4.css was specifiying a default background-color for
   buttons which meant that we could never tell if the page
   was setting one (which we should observe) or not (in
   which case we should draw our default button). So I added
   a CSS snippet to override this.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list