[Webkit-unassigned] [Bug 26084] Multiple missing images in webkit-mask-image prevent rendering

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26084


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30865|review?                     |review-
               Flag|                            |




------- Comment #7 from darin at apple.com  2009-06-02 12:22 PDT -------
(From update of attachment 30865)
> +		Bug 26084: Multiple missing images in webkit-mask-image prevent rendering
> +		When painting multiple images, make sure that at least one image is valid before
> +		pushing a transparency layer.        

There are tabs here, and in the patch itself too. A patch with tabs can't be
landed until the tabs are replaced with spaces; having tabs in the patch makes
additional work for the person trying to commit the patch.

It's also good to include the bugs.webkit.org URL for the bug.

> Index: LayoutTests/fast/css/mask-composite-missing-images.html
> ===================================================================
> --- LayoutTests/fast/css/mask-composite-missing-images.html	(revision 0)
> +++ LayoutTests/fast/css/mask-composite-missing-images.html	(revision 0)
> @@ -0,0 +1,17 @@
> +<style>
> +.test {
> +    width: 200px;
> +    height: 200px;
> +    border:10px solid black;
> +    background-color:lime;
> +    -webkit-mask-image: url(url-not-found), url(url-not-found), url(url-not-found), url(url-not-found), url(url-not-found), url(url-not-found), url(url-not-found), url(url-not-found), url(url-not-found);
> +    -webkit-mask-position: top left, top right, bottom left, bottom right, top center, center right, bottom center, center left, center;
> +    -webkit-mask-origin: border;
> +    -webkit-mask-repeat: no-repeat, no-repeat, no-repeat, no-repeat, repeat-x, repeat-y, repeat-x, repeat-y, repeat;
> +    -webkit-mask-composite: copy;
> +}
> +</style>
> +
> +<p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=26084">WebKit Bug 26084: Bug 26084: Multiple missing images in webkit-mask-image prevent rendering</a></p>
> +<div class="test">This text should be visible.</div>
> +<p>If the test passes, you should be able to see a lime square with a black border. Inside the border, you should see the text: This text should be visible.</p>
> \ No newline at end of file

If this is a manual test, then it needs to go in WebCore/manual-tests, not in
LayoutTests.

Please put a newline at the end of the file.

review- because this adds a test to the LayoutTests directory without including
expected results.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.