[Webkit-unassigned] [Bug 26103] [GTK] Remove gtk/cairo/pango/freetype/fontconfig includes from the header files in WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26103





------- Comment #7 from bunk at stusta.de  2009-06-02 01:18 PDT -------
(In reply to comment #6)
> (In reply to comment #5)
> > Disclaimer: I am not a WebKit developer.
> > 
> > First of all, sorry for misunderstanding the purpose of your patch.
> > 
> > But I do dislike your patch since it breaks the proper abstractions.
> > An example:
> 
> Okay, I think you are slightly off again + my description not being too good.
> My goal is to not have any glib/glib.h, cairo.h in WebCore header files as this
> is increasing compile times (see this simple patch can save quite some time).
> 
> Way to get there include:
>   - use forward declarations... and they are typesafe, e.g. if I declare
> typedef struct _GtkEntry GtkWidget the compiler will shout at me.
> 
>   - do not use Glib types when not necessary. Using unsigned long long was a
> bit too much to store the value 8192, so an updated patch will use unsigned.
> See how I just didn't do typedef unsigned long gsize?
>...

OK, so this seems to work.

But what would e.g. happen if with a future (ABI-incompatible) version of glib
"typedef gint gboolean;" would no longer be true?

Overally, my personal opinion is that your patch is going into the wrong
direction - even if my suspicion that it might also be wrong on some technical
details turns out to be wrong.

But I am not a WebKit developer, I only ran into this bug when looking for
completely different issues, and I'm gonna keep my mouth shut on it now.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.