[Webkit-unassigned] [Bug 26103] [GTK] Remove gtk/cairo/pango/freetype/fontconfig includes from the header files in WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26103





------- Comment #5 from bunk at stusta.de  2009-06-01 17:51 PDT -------
Disclaimer: I am not a WebKit developer.

First of all, sorry for misunderstanding the purpose of your patch.

But I do dislike your patch since it breaks the proper abstractions.

An example:

-        gsize m_bufferSize, m_total;
+        unsigned long long m_bufferSize, m_total;

gsize might be "unsigned long long" on your FreeBSD machine.

But not on my x86 Linux machine (with a 64bit userspace it's "unsigned long",
and with a 32bit userspace it's "unsigned int").

glib has an autoconf test for determining the type of gsize. Do you really want
to duplicate that in WebKit?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.