[Webkit-unassigned] [Bug 25899] [Chromium] PC Chromium: keyboard selection in Hebrew select element doesn't work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25899


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30687|review?                     |review-
               Flag|                            |




------- Comment #8 from eric at webkit.org  2009-06-01 12:03 PDT -------
(From update of attachment 30687)
I think this should be separated out into a static function.  Then the code
becomes:

if (isCharacterForPrefixString(event))
   m_lastCharTime = now;
(Or some other equally suitable or better name)

And the long comment can be inside the static function, as well as the #if
usage.

This also needs a test case.  Even if it's just a manual test in
WebCore/manual-tests/

I would expect there is a way to test this using eventSender though, so you
could make an automated test.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.