[Webkit-unassigned] [Bug 25902] Need to implement WorkerContext.close()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 1 00:35:27 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=25902


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30752|review?                     |review+
               Flag|                            |




------- Comment #10 from darin at apple.com  2009-06-01 00:35 PDT -------
(From update of attachment 30752)
I normally prefer early return to nesting work inside if statements. So in
close and postMessage we'd put:

    if (m_closing)
        return;

At the start of the function, and then go on with the work of the function.

I much prefer change logs with per-function comments.

Given Alexey's previous comments this looks good. r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list