[Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27430


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33059|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-07-31 20:05:47 PDT ---
(From update of attachment 33059)
WebCore avoids using superfluous argument names in headers:
 91     gpointer toGDOM(DOMWindow* doc);
 92     gpointer toGDOM(Document* doc);
 93     gpointer toGDOM(XMLHttpRequest* obj);

We don't commit commented out code:
 407     //WebKitWebFramePrivate* priv = frame->priv;

Name:
 2536 2008-11-30  lkcl  <lkcl at lkcl.net>

Otherwise looks fine.  I mean, I'm not really a gtk expert.  There are style
violations, but I assume this stuff is more supposed to be more gtk style than
webkit style, not sure.

r- for the above nits.  If you were a committer I could just r+ it and let you
fix it as you landed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.