[Webkit-unassigned] [Bug 27424] adding ConvertToGCharPrivate.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27424


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33388|review?                     |review-
               Flag|                            |




--- Comment #9 from Eric Seidel <eric at webkit.org>  2009-07-31 20:01:18 PDT ---
(From update of attachment 33388)
Most of the rest of WebCore follows the "copy rule", which would name these
with "copy" in their name since you're copying the data, or create.

copyAsGchar()
or
createGcharFromString()

I've never seen this:
23 /*
 24  * added under bug #27424 - 19jul2009
 25  */

Seems superfluous, given that we have a version control system.

I'm also not sure what Private_h is for, but that was discussed in the long
comments above (which I admit to not reading, given their length).

So overall these look fine.  I'm not a huge fan of the convert name, but it's
also not a dealbreaker.

Since you're not a committer yet, r- for the unneeded comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.