[Webkit-unassigned] [Bug 27902] Missing default switch for baselineShift case statement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27902


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33909|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2009-07-31 17:47:05 PDT ---
(From update of attachment 33909)
By adding the default case, you are turning off the gcc feature that complains
if an enum value is not handled in a switch statement.

So you are turning off compile-time detection (under gcc) of the very thing you
are trying to catch at runtime.

And compile-time detection is even better, so we don't want it turned off!

Please put the assertion outside the switch statement instead of adding a
default case. Or just drop this while thing, since we'll catch missing enum
values immediately due to gcc's warning as soon as this file is compiled with
gcc.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.