[Webkit-unassigned] [Bug 27904] New: notImplemented() is too subtle

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 31 17:16:51 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27904

           Summary: notImplemented() is too subtle
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jorlow at chromium.org


I was just debugging a problem and found out that notImplemented() was being
called but I had never noticed.  I looked at the source code, and this is all
it does:

#define notImplemented() do { \
        static bool havePrinted = false; \
        if (!havePrinted && !supressNotImplementedWarning()) { \
            WTFLogVerbose(__FILE__, __LINE__, WTF_PRETTY_FUNCTION,
&::WebCore::LogNotYetImplemented, "UNIMPLEMENTED: "); \
            havePrinted = true; \
        } \
    } while (0)

I'm wondering why this doesn't do something more obvious.  Isn't hitting
not-implemented code kind of a big deal?  Shouldn't we do an assert so that
someone who's debugging sees it?

If we want to fix this, feel free to assign to me and I can take care of it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list