[Webkit-unassigned] [Bug 27902] New: Missing default switch for baselineShift case statement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27902

           Summary: Missing default switch for baselineShift case
                    statement
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jhawkins at google.com
                CC: eric at webkit.org


case CSSPropertyBaselineShift: {
    switch (svgStyle->baselineShift()) {
        case BS_BASELINE:
            return CSSPrimitiveValue::createIdentifier(CSSValueBaseline);
        case BS_SUPER:
            return CSSPrimitiveValue::createIdentifier(CSSValueSuper);
        case BS_SUB:
            return CSSPrimitiveValue::createIdentifier(CSSValueSub);
        case BS_LENGTH:
            return svgStyle->baselineShiftValue();
    }
}
case CSSPropertyGlyphOrientationHorizontal:
    return
glyphOrientationToCSSPrimitiveValue(svgStyle->glyphOrientationHorizontal());

If svgStyle->baselineShift() does not match any of the above four values, which
could only happen if parsing was added for the value and not added here, then
we'd return a value from glyphOrientationToCSSPrimitiveValue().  I basically
copied the comment and assertion from a couple lines below, which checks for
the same case on different level.  Attaching patch shortly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.