[Webkit-unassigned] [Bug 27844] SVG Filter and linearRGB, sRGB platform support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27844


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33796|review?                     |review+
               Flag|                            |




--- Comment #3 from Oliver Hunt <oliver at apple.com>  2009-07-31 16:14:25 PDT ---
(From update of attachment 33796)
> +void ImageBuffer::transformColorSpace(ImageColorSpace srcColorSpace, ImageColorSpace dstColorSpace)
> +{
...
> +    if (dstColorSpace == LinearRGB) {
> +        if (m_linearRgbLUT.isEmpty()) {
...
> +        lookUpTable = m_linearRgbLUT;
> +    }
> +    if (dstColorSpace == DeviceRGB) {
...
> +    }
should be 'else if' here

> +        case LinearRGB:
> +			colorSpace = CGColorSpaceCreateWithName(kCGColorSpaceGenericRGBLinear);
indenting :D

I share eric's concern about the placement of the colour matching logic --
logically it should be in GraphicsContext, but i don't think it's feasible to
do the required logic to ensure that behaviour is correct outside of the
underlying graphics library so this placement seems the only place it can
really go for now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.