[Webkit-unassigned] [Bug 27883] [v8] check if proxy is present before invoking a handler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27883





--- Comment #4 from anton muhin <antonm at chromium.org>  2009-07-31 12:07:35 PDT ---
(In reply to comment #2)
> (From update of attachment 33878 [details])
> > Index: third_party/WebKit/WebCore/ChangeLog
> > +2009-07-31  Anton Muhin  <antonm at chromium.org>
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> 
> Please add:
> 
> Bug Title
> Bug Link
> 
> "prepare-ChangeLog --bug #" will do this for you.

Hopefully done. Thanks a lot for pointing out a flag.  Could this information
be added to http://webkit.org/coding/contributing.html (just asking)

> 
> > +        Do not invoke handler functio if proxy is NULL (that would lead to NPE anyway).
> 
> typo: functio

Tnx, done.

> 
> Change NULL to 0 (since WebKit doesn't use NULL).
> 
> NPE is not an abbreviation that I'm familiar with but I guess you mean
> crash/access violation.  It would be good to write it in a longer form without
> using an abbreviation.

Hopefully done.
> 
> Also, this ChangeLog explains what but not why.  Please add why.

The problem is I don't know why (that's why I think we could drop this
patch)---I think error is higher level, but I don't know enough to find the
proper place.

> 
> 
> Can there be a layout test for whatever problem was encountered?
>   If so, please add one.
>   If not, why not?

See above.  Sorry for repetition, but you, David, may know better person to
track this down---I believe the problem is in higher levels (but in that case
I'd like to see ASSERT here instead my poor if)---I can understand that if
event listener could be invoked, there should be proxy.  However, I am
definitely not a person to understand every minutae of the stuff.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.