[Webkit-unassigned] [Bug 27873] [Patch] Fix compile error for ambigous call to abs()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27873


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33869|review?                     |review+
               Flag|                            |




--- Comment #1 from Darin Adler <darin at apple.com>  2009-07-31 09:33:49 PDT ---
(From update of attachment 33869)
Another approach we use for issues like this is to put code in MathExtras.h to
work around platform differences. Take a look at MathExtras.h to see what I
mean.

But this change seems OK.

I think the change log is not so good. It says "fix compilation" which is far
too vague. The bug mentions the QNX platform and the change log should too.

I'm going to say r=me, though, because this seems like a good fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.