[Webkit-unassigned] [Bug 27883] [v8] check if proxy is present before invoking a handler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27883


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33878|review?                     |review-
               Flag|                            |




--- Comment #2 from David Levin <levin at chromium.org>  2009-07-31 09:19:04 PDT ---
(From update of attachment 33878)
> Index: third_party/WebKit/WebCore/ChangeLog
> +2009-07-31  Anton Muhin  <antonm at chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +

Please add:

Bug Title
Bug Link

"prepare-ChangeLog --bug #" will do this for you.

> +        Do not invoke handler functio if proxy is NULL (that would lead to NPE anyway).

typo: functio

Change NULL to 0 (since WebKit doesn't use NULL).

NPE is not an abbreviation that I'm familiar with but I guess you mean
crash/access violation.  It would be good to write it in a longer form without
using an abbreviation.

Also, this ChangeLog explains what but not why.  Please add why.


Can there be a layout test for whatever problem was encountered?
  If so, please add one.
  If not, why not?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.