[Webkit-unassigned] [Bug 27762] [v8] Cache atomic strings in externalized v8 strings
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 31 09:15:04 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=27762
--- Comment #30 from Christian Plesner Hansen <christian.plesner.hansen at gmail.com> 2009-07-31 09:15:03 PDT ---
> This should be
> if (!m_plainString.impl()->inTable())
Eek, how did I get this wrong?!?
> Also the name "forString" doesn't read that well to me. How about
> toStringResource? (toString may have worked but there are so many *String* in
> here, that I thought it would be nice to distinguish.)
That's a v8-ism inherited, I believe, from SmallTalk. I've changed it.
> And as discussed, this solution removed the duplicate code but increased memory
> usage unnecessarily.
I've changed it to avoid that.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list