[Webkit-unassigned] [Bug 27866] [Qt] Initialize HTML5 Application Cache for QtWebKit to a sensible default

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27866


Tor Arne Vestbø <vestbo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33856|review?                     |review+
               Flag|                            |




--- Comment #6 from Tor Arne Vestbø <vestbo at webkit.org>  2009-07-31 06:34:47 PDT ---
(From update of attachment 33856)
Looks good! A minor nitpick, just fix before landing:

> +static void WebKitInitializeApplicationCachePathIfNecessary()

Should be named initializeApplicationCachePathIfNecessary(), ie no WebKit
prefix, and start with lower-case.

Actually this is not in the coding style guidelines, but I think the lower case
variant is more prevalent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.