[Webkit-unassigned] [Bug 27876] Expose the Offline Web Application Cache API in the Qt API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27876


Tor Arne Vestbø <vestbo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33873|review?                     |review+
               Flag|                            |




--- Comment #1 from Tor Arne Vestbø <vestbo at webkit.org>  2009-07-31 06:22:37 PDT ---
(From update of attachment 33873)
looks good, but we have to do an api review of all of this offline/cache stuff
before the release. a few nitpicks:

> @@ -358,7 +358,6 @@ QWebSettings::QWebSettings()
>      d->attributes.insert(QWebSettings::LocalStorageDatabaseEnabled, true);
>      d->attributes.insert(QWebSettings::LocalContentCanAccessRemoteUrls, true);
>      d->offlineStorageDefaultQuota = 5 * 1024 * 1024;
> -
>  }

Whitespace change, please remove.

> @@ -785,10 +784,17 @@ qint64 QWebSettings::offlineStorageDefaultQuota()
>  }
>  
>  /*
> -    \internal
> +    \since 4.6
>      \relates QWebSettings
>  
>      Sets the path for HTML5 offline web application cache storage to \a path.

Please add linebreak here.

> +    An application cache acts like an HTTP cache in some sense. For documents
> +    that use the application cache via JavaScript, the loader mechinery will
> +    first ask the application cache for the contents, before hitting the
> +    network.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.