[Webkit-unassigned] [Bug 27706] WebCore NPAPI implementations should share more code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27706


Tor Arne Vestbø <vestbo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |vestbo at webkit.org
                   |kit.org                     |




--- Comment #11 from Tor Arne Vestbø <vestbo at webkit.org>  2009-07-31 05:38:25 PDT ---
Thanks for the reviews Anders!

On the subject of defines, what's the exact meaning of
ENABLE(NETSCAPE_PLUGIN_API)? Does it refer to the NPAPI-JS-bindings only, or
NPAPI support in general? 

The reason I'm asking is that the Mac NPAPI implementation in WebKit wrap all
files with #if ENABLE(NETSCAPE_PLUGIN_API), but in the WebCore NPAPI
implementations it's a little more spread out, for example only around
PluginView::userAgentStatic() and PluginView::getValueStatic(). What's the
correct usage of this macro/define? 

Thanks :D

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.