[Webkit-unassigned] [Bug 27762] [v8] Cache atomic strings in externalized v8 strings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27762





--- Comment #27 from Christian Plesner Hansen <christian.plesner.hansen at gmail.com>  2009-07-31 03:35:23 PDT ---
Fixed all issues except one.  I don't see any tabs in the ChangeLog but I had
to create a new one anyway so if there were any they should be gone now.

There is one potential issue left though.  Is is correct that an atomic thread
created on one thread cannot safely be used on another?  Or is it just that the
operation of making a string atomic is not thread safe?  If it is the first
case then as far as I can see plain String objects can't be shared either,
which my changes assume they can.

> Please get the patch to be based from WebKit or else it will be harder to
> commit this for you (i.e. in this case, all path for files below should be
> prefixed with WebCore/).

On linux, using svn-create-patch from third_party/WebKit gave me an empty patch
so I had to be a little creative.  Let me know if the patch gives you any
problems.

> Why is it m_atomicImpl instead of just m_atomicString?

Renamed one to m_plainString and the other to m_atomicString to make it clear
what the difference is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.