[Webkit-unassigned] [Bug 27792] [GTK] new-window-policy-decision-requested provides no information about the target frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27792


Jan Alonzo <jmalonzo at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #10 from Jan Alonzo <jmalonzo at gmail.com>  2009-07-30 23:18:36 PDT ---
(In reply to comment #9)
> (From update of attachment 33779 [details])
> > +    g_object_class_install_property(objectClass, PROP_TARGET_FRAME,
> > +                                    g_param_spec_string("target-frame",
> > +                                                        _("Target frame"),
> > +                                                        _("The target frame for the navigation"),
> > +                                                        "",
> > +                                                        (GParamFlags)(WEBKIT_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY)));
> 
> This should be initialized to NULL.
> 
> r=me. I'll fixed the nit prior to landing.

Landed as http://trac.webkit.org/changeset/46622. 

I simplified the strcmp expression in set_target_frame as suggested by Xan in
IRC. I also changed the return type of get_target_frame from "const char*" to
"G_CONST_RETURN gchar*" to make it consistent with most of WebKitGtk API that
return a "const char*".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.