[Webkit-unassigned] [Bug 27821] ApplicationCacheHost refactoring

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27821





--- Comment #8 from Michael Nordman <michaeln at google.com>  2009-07-30 15:24:11 PDT ---
> nit: It is encouraged to delete these lines that list functions in new
> files being added.  The point, I gather, is that the function list is
> most interesting when existing files are being modified.

done

> nit: isEmpty() is all you need since it returns true if the string is
> either null or zero-length.

done, thnx

> nit: Can this just be a non-pointer member variable?  It isn't lazily
> allocated.

done, involved 'forwarding' ApplicationCacheHost.hand DOMApplicationCache.h) to
the webkit layer, so the xcodeproject file changed too

> nit: you can probably get away with just forward declaring KURL, right?

done, thnx

> nit: Instead of creating a new enum type, perhaps it would have been better
> to just pass an AtomicString for the event name?  What does the enum buy us
> over just using the event name directly?

leaving as is, its used as a 'c' array index too 

> I don't think this change is correct or necessary.  See page/ChromeClient.h.

done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.