[Webkit-unassigned] [Bug 27847] bugzilla-tool post-commits trunk..head errors out

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27847


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33832|review?                     |review+
               Flag|                            |




--- Comment #6 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2009-07-30 15:03:03 PDT ---
(From update of attachment 33832)

> +    # This function supports the following argument formats:
> +    # no args : rev-list trunk..HEAD
> +    # A..B    : rev-list A..B
> +    # A...B   : error!
> +    # A B     : [A, B]  (different from git diff, which would use "rev-list A..B")
> +    def commit_ids_from_commitish_arguments(self, args):
> +        if not len(args):
> +            args.append('trunk..HEAD')
> +
> +        commit_ids = []
> +        for commitish in args:
> +            if '...' in commitish:
> +                error("'...' is not supported (found in %s). Did you mean '..'?" % commitish)
> +            elif '..' in commitish:
> +                commit_ids += self.run_command(['git', 'rev-list', commitish]).splitlines()
> +            else:
> +                commit_ids.append(commitish)
> +        return commit_ids

I think individual commits should still be passed through git rev-parse:

> +            else:
> +                commit_ids += self.run_command(['git', 'rev-parse', '--revs-only', commitish]).splitlines()

This allows you to specify a branch name or a tag name that turns into a single
commit.

r=me with this change. Everything else looks good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.