[Webkit-unassigned] [Bug 27821] ApplicationCacheHost refactoring

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 30 12:58:50 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27821


Michael Nordman <michaeln at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33759|review?                     |
               Flag|                            |
  Attachment #33759|0                           |1
        is obsolete|                            |
  Attachment #33810|                            |review?
               Flag|                            |




--- Comment #5 from Michael Nordman <michaeln at google.com>  2009-07-30 12:58:48 PDT ---
Created an attachment (id=33810)
 --> (https://bugs.webkit.org/attachment.cgi?id=33810)
class ApplicationCacheHost rev3

For whatever reason...

private:
    friend class RefCounted<DOMApplicationCache>;
    ~DOMApplicationCache() {}

... doesn't compile with msvc (the RefCounted base class does not have access
to the dtor).  Removing the 'class' keyword does compile with msvc, but then
gcc is unhappy about that. So... bailing on hiding the dtor, moved it to the
public section (which is generally how webcore refcounted classes are).

no other changes

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list