[Webkit-unassigned] [Bug 27847] bugzilla-tool post-commits trunk..head errors out

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 30 12:14:08 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27847





--- Comment #4 from Eric Seidel <eric at webkit.org>  2009-07-30 12:14:07 PDT ---
I think we're defining new behavior here.  "git show" expects to cherry pick
what is passed it.  But it doesn't accept ranges.  "git diff" will take a
single commit passed to it and turn it into "COMMIT..HEAD" (which is what
git-send-bugzilla used to do).  So our behavior is different and will need some
custom code (at least as far as I can tell).

Also, as Evan could tell you, "..." are treated differently for different
commands.  I think "..." makes no sense for us, and anyone passing it to
post-commits likely meant ".." and did so in error, so I think we should error
out.

For sanity sake, we could print 1-line descriptions of what we're about to
upload before we do so.  We could even ask for confirmation, although that's
probably unnecessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list