[Webkit-unassigned] [Bug 27774] [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27774


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33789|review?                     |review+
               Flag|                            |




--- Comment #7 from Gustavo Noronha (kov) <gns at gnome.org>  2009-07-30 09:55:49 PDT ---
(From update of attachment 33789)
> -    } else {
> +    } else
>          g_object_set(G_OBJECT(m_playBin), "volume", m_volume, NULL);
> -    }
> +
>  }

I'd remove this line.

> -            LOG_VERBOSE(Media, "m_source is NULL");
> +            LOG_VERBOSE(Media, "m_source is 0");

I think you want to keep this as NULL here.

Other than that looks good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.