[Webkit-unassigned] [Bug 27792] [GTK] new-window-policy-decision-requested provides no information about the target frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27792





--- Comment #6 from Xan Lopez <xan.lopez at gmail.com>  2009-07-30 01:12:32 PDT ---
(In reply to comment #5)
> Created an attachment (id=33715)
 --> (https://bugs.webkit.org/attachment.cgi?id=33715) [details]
> Updated patch
> 
> Added a patch with the changes suggested.

Only two nitpicks:

- The set_target_frame function should be static now.
- Maybe we should set the target frame to 'NULL' to indicate that it's not set,
instead of ""?

Other than that it looks good to me. Since this adds new API I'll let another
reviewer give the final r+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.